Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore notebook toolbar under jlab4 - fix for issue #1107 #1109

Merged
merged 3 commits into from
Jul 28, 2023
Merged

restore notebook toolbar under jlab4 - fix for issue #1107 #1109

merged 3 commits into from
Jul 28, 2023

Conversation

parmentelat
Copy link
Contributor

@parmentelat parmentelat commented Jul 27, 2023

a fix for solving issue #1107

here's what both widgets (Notebook and Jupytext Notebook) look like

image


as can be seen on the screenshot there remains issues related to extensions
here I have installed jupyterlab-courselevels that adds some buttons in the toolbar; and what happens is that these buttons show up in the pure Notebook (ipynb) widget but not in the Jupytext Notebook widget

IMO this PR is still very welcome because

  • the situation is far better than it was before this work
  • I suspect that getting this to work perfectly is something very tricky
  • especially considering that we build in a jlab3 environment, where some of the symbols that are, I think, needed to solve this properly, are not defined to typescript

So @mwouts I would be grateful if you could publish this under pypi - it is already versioned as 1.15.0.dev2

indeed with jlab4 we need to duplicate the code that creates the notebook toolbar
this version is much nicer already, but still builds an incomplete toolbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants