Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dates and RegExps are neither primitives nor plain objects #233

Closed
aleclarson opened this issue Oct 27, 2018 · 3 comments
Closed

Dates and RegExps are neither primitives nor plain objects #233

aleclarson opened this issue Oct 27, 2018 · 3 comments
Assignees
@aleclarson
Labels
bug has PR

Comments

@aleclarson
Copy link
Member

Date and RegExp objects cannot be passed to produce without an error being thrown.

https://codesandbox.io/s/rrz9lq7pwp
@aleclarson aleclarson added the bug label Oct 27, 2018
@aleclarson
Copy link
Member Author

Boxed primitives also cause a throw.

@aleclarson aleclarson mentioned this issue Oct 29, 2018
Closed
@aleclarson
Copy link
Member Author

aleclarson commented Oct 29, 2018 •
edited
Loading

We should treat non-plain objects as primitives (eg: avoid creating a draft).

edit: See #236.

@aleclarson aleclarson self-assigned this Oct 29, 2018
@aleclarson aleclarson mentioned this issue Oct 29, 2018
Merged
@mweststrate
Copy link
Collaborator

Releases as 1.8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleclarson aleclarson

Labels
bug has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @aleclarson