Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in stefcal step for polarized calibration #53

Open
mweastwood opened this issue May 26, 2016 · 2 comments
Open

error in stefcal step for polarized calibration #53

mweastwood opened this issue May 26, 2016 · 2 comments

Comments

@mweastwood
Copy link
Owner

@marinanderson You should probably double check my math, but I think I found an error in the stefcal step for polarized calibration here:

step[j] = ifelse(ok, (denominator\numerator)' - input[j], zero(T))

I think the update step actually needs to be conj(denominator\numerator) instead of (denominator\numerator)' (which does a conjugate transpose).

@mweastwood
Copy link
Owner Author

Eh, now I'm not so sure. All the tests break if I make this change. Maybe it is ok after all?

@mweastwood
Copy link
Owner Author

xy = complex(real(visibilities.data[α,β].xy*fringe), -imag(visibilities.data[α,β].yx*fringe))

The above line is incorrect. Fixed on the devel branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant