Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandas 0.17.0rc1 #702

Closed
jreback opened this issue Sep 11, 2015 · 6 comments
Closed

pandas 0.17.0rc1 #702

jreback opened this issue Sep 11, 2015 · 6 comments

Comments

@jreback
Copy link

jreback commented Sep 11, 2015

we have some fairly significant changes and would like you to test and provide any feedback: https://github.com/pydata/pandas/releases/tag/v0.17.0rc1

thanks!
@jreback jreback mentioned this issue Sep 11, 2015
Closed
2 tasks
@mwaskom
Copy link
Owner

mwaskom commented Sep 11, 2015

Thanks for the heads up. Some failures I need to sort out.

Any idea why the warning about the sort API deprecation is getting raised from a weird place?

../Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division

@mwaskom
Copy link
Owner

mwaskom commented Sep 11, 2015

For posterity

(pandas_dev)[mwmp seaborn]{master}$ make test
cp testing/matplotlibrc .
nosetests --with-doctest
/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/indexing.py:115: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame

See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
  self._setitem_with_indexer(indexer, value)
/Users/mwaskom/code/seaborn/seaborn/axisgrid.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
F/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/matplotlib/pyplot.py:424: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`).
  max_open_warning, RuntimeWarning)
../Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
./Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
.../Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
./Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
./Users/mwaskom/code/seaborn/seaborn/categorical.py:1: FutureWarning: sort(columns=....) is deprecated, use sort_values(by=.....)
  from __future__ import division
........./Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/matplotlib/colorbar.py:215: UserWarning: Use the colorbar set_ticks() method instead.
  warnings.warn("Use the colorbar set_ticks() method instead.")
..........................................S.........................................................................................................................................................................................................................................SS..........................................................................................................SSS
======================================================================
FAIL: Doctest: seaborn.axisgrid.FacetGrid.__init__
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/doctest.py", line 2226, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for seaborn.axisgrid.FacetGrid.__init__
  File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 389, in __init__

----------------------------------------------------------------------
File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 605, in seaborn.axisgrid.FacetGrid.__init__
Failed example:
    df = pd.DataFrame(
        data=np.random.randn(90, 4),
        columns=pd.Series(list("ABCD"), name="walk"),
        index=pd.date_range("Jan 1", "March 31", name="date"))
Exception raised:
    Traceback (most recent call last):
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest seaborn.axisgrid.FacetGrid.__init__[34]>", line 4, in <module>
        index=pd.date_range("Jan 1", "March 31", name="date"))
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tseries/index.py", line 1913, in date_range
        closed=closed)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/util/decorators.py", line 89, in wrapper
        return func(*args, **kwargs)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tseries/index.py", line 236, in __new__
        ambiguous=ambiguous)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tseries/index.py", line 385, in _generate
        start = Timestamp(start)
      File "pandas/tslib.pyx", line 298, in pandas.tslib.Timestamp.__new__ (pandas/tslib.c:8496)
      File "pandas/tslib.pyx", line 1146, in pandas.tslib.convert_to_tsobject (pandas/tslib.c:21832)
      File "pandas/tslib.pyx", line 1277, in pandas.tslib.convert_str_to_tsobject (pandas/tslib.c:23893)
      File "pandas/tslib.pyx", line 1211, in pandas.tslib.convert_to_tsobject (pandas/tslib.c:22873)
      File "pandas/tslib.pyx", line 1415, in pandas.tslib._check_dts_bounds (pandas/tslib.c:26119)
    OutOfBoundsDatetime: Out of bounds nanosecond timestamp: 1-01-01 00:00:00
----------------------------------------------------------------------
File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 609, in seaborn.axisgrid.FacetGrid.__init__
Failed example:
    df = df.cumsum(axis=0).stack().reset_index(name="val")
Exception raised:
    Traceback (most recent call last):
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest seaborn.axisgrid.FacetGrid.__init__[35]>", line 1, in <module>
        df = df.cumsum(axis=0).stack().reset_index(name="val")
    NameError: name 'df' is not defined
----------------------------------------------------------------------
File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 614, in seaborn.axisgrid.FacetGrid.__init__
Failed example:
    g = sns.FacetGrid(df, col="walk", col_wrap=2, size=3.5)
Exception raised:
    Traceback (most recent call last):
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest seaborn.axisgrid.FacetGrid.__init__[37]>", line 1, in <module>
        g = sns.FacetGrid(df, col="walk", col_wrap=2, size=3.5)
    NameError: name 'df' is not defined
----------------------------------------------------------------------
File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 615, in seaborn.axisgrid.FacetGrid.__init__
Failed example:
    g = g.map_dataframe(dateplot, "date", "val")
Exception raised:
    Traceback (most recent call last):
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest seaborn.axisgrid.FacetGrid.__init__[38]>", line 1, in <module>
        g = g.map_dataframe(dateplot, "date", "val")
      File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 792, in map_dataframe
        self._facet_plot(func, ax, args, kwargs)
      File "/Users/mwaskom/code/seaborn/seaborn/axisgrid.py", line 810, in _facet_plot
        func(*plot_args, **plot_kwargs)
      File "<doctest seaborn.axisgrid.FacetGrid.__init__[36]>", line 4, in dateplot
        data.plot(x=x, y=y, ax=ax, grid=False, **kwargs)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tools/plotting.py", line 3610, in __call__
        sort_columns=sort_columns, **kwds)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tools/plotting.py", line 2495, in plot_frame
        **kwds)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/tools/plotting.py", line 2303, in _plot
        data = data.set_index(x)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/frame.py", line 2726, in set_index
        level = frame[col]._values
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/frame.py", line 1915, in __getitem__
        return self._getitem_column(key)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/frame.py", line 1922, in _getitem_column
        return self._get_item_cache(key)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/generic.py", line 1090, in _get_item_cache
        values = self._data.get(item)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/internals.py", line 3052, in get
        loc = self.items.get_loc(item)
      File "/Users/mwaskom/anaconda/envs/pandas_dev/lib/python2.7/site-packages/pandas/core/index.py", line 1685, in get_loc
        return self._engine.get_loc(_values_from_object(key))
      File "pandas/index.pyx", line 137, in pandas.index.IndexEngine.get_loc (pandas/index.c:3979)
      File "pandas/index.pyx", line 157, in pandas.index.IndexEngine.get_loc (pandas/index.c:3843)
      File "pandas/hashtable.pyx", line 668, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:12265)
      File "pandas/hashtable.pyx", line 676, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:12216)
    KeyError: 'date'


----------------------------------------------------------------------
Ran 405 tests in 160.745s

FAILED (SKIP=6, failures=1)
make: *** [test] Error 1

@jreback
Copy link
Author

jreback commented Sep 11, 2015

@mwaskom yep, we were afraid of the downstream deprecation showing (so maybe we will make it a DeprecationWarning rather than a FutureWarning

@jreback
Copy link
Author

jreback commented Sep 11, 2015

pd.date_range("Jan 1", "March 31", name="date") was 'accidently working', see here down a little ways and is not valid. replace by actual dates.

@jreback
Copy link
Author

jreback commented Sep 27, 2015

any remaining issues with the rc1?

@mwaskom
Copy link
Owner

mwaskom commented Sep 27, 2015

Sorry I've had 0 bandwidth for seaborn recently. IIRC, the only issues were with how I was invoking pandas in the doctests, so I don't think you should consider anything a blocker from my side

@mwaskom mwaskom mentioned this issue Oct 25, 2015
Merged
@jorisvandenbossche jorisvandenbossche mentioned this issue Oct 25, 2015
Closed
@mwaskom mwaskom closed this as completed Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwaskom @jreback