Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line + Band with variables that Band does not support is awkward #2982

Open
mwaskom opened this issue Aug 28, 2022 · 0 comments
Open

Line + Band with variables that Band does not support is awkward #2982

mwaskom opened this issue Aug 28, 2022 · 0 comments

Comments

@mwaskom
Copy link
Owner

mwaskom commented Aug 28, 2022

Band does not support linestyle, so this plot is wrong in a confusing way:

(
    so.Plot(fmri, "timepoint", "signal", color="region", linestyle="event")
    .add(so.Line(), so.Agg())
    .add(so.Band(), so.Est())
)

image

One needs to do this:

(
    so.Plot(fmri, "timepoint", "signal", color="region", linestyle="event")
    .add(so.Line(), so.Agg())
    .add(so.Band(), so.Est(), group="event")
)

image

Perhaps the stat grouping should use any variables defined at the common level or in that layer, not just those the mark accepts?

This will have some implications as we address #2911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant