From 38f2efa7e732958430c006f24827c6ac69640ef3 Mon Sep 17 00:00:00 2001 From: Michael Waskom Date: Sat, 17 Jul 2021 16:03:34 -0400 Subject: [PATCH] Fix non-cartesian interior labels --- seaborn/_core/plot.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/seaborn/_core/plot.py b/seaborn/_core/plot.py index b68be8209a..7766efada7 100644 --- a/seaborn/_core/plot.py +++ b/seaborn/_core/plot.py @@ -472,13 +472,12 @@ def _setup_figure(self, pyplot: bool = False) -> None: }) axis_obj = getattr(ax, f"{axis}axis") - if self._subplotspec.get("cartesian", True): - label_side = {"x": "bottom", "y": "left"}.get(axis) - visible = sub[label_side] - axis_obj.get_label().set_visible(visible) - # TODO check that this is the right way to set these attributes - plt.setp(axis_obj.get_majorticklabels(), visible=visible) - plt.setp(axis_obj.get_minorticklabels(), visible=visible) + side = {"x": "bottom", "y": "left"}.get(axis) + visibility = sub[side] or not self._pairspec.get("cartesian", True) + axis_obj.get_label().set_visible(visibility) + # TODO check that this is the right way to set these attributes + plt.setp(axis_obj.get_majorticklabels(), visible=visibility) + plt.setp(axis_obj.get_minorticklabels(), visible=visibility) # TODO title template should be configurable # TODO Also we want right-side titles for row facets in most cases