Support for Nextcloud 25

[mwalbeck]

Nextcloud 25 is a big change from previous Nextcloud version when it comes to visuals and theming. This probably means it will take longer than normal to update the plugin.

[AkechiShiro]

Hey @mwalbeck, any way, we could help/contribute to this update?

In the README, I saw that a test environment is needed, with a Nextcloud server being set up and just a simple text editor, cloning the repo in the Nextcloud app directory, with this it could be possible to start porting the look/visuals into NC25 ?

Could you describe the process of working on this ? Is it just about editing CSS files ? Should php/js files also modified ? I suppose any PR should be made to the branch 25.

I've taken a quick look here : bce6264 I guess there is still some stuff that is broken ?

[p-bo]

@mwalbeck

Nextcloud 25 is a big change from previous Nextcloud version when it comes to visuals and theming. This probably means it will take longer than normal to update the plugin.

(Just in case it wasn't noticed) - but at least now Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo

[mwalbeck]

Hey @AkechiShiro thanks for taking the interest!

There are a few of things that dragged out this release:

1. Nextcloud has introduced a new way of handling their own themes which more or less broke how I was handling the theming. Both with overwriting CSS and with how the enabling and disabling of the theme functions. This is the main things I've been working on so far. It mainly entails spelunking around Nextcloud code to figure out how the theme can best interact with the new Nextcloud system, and then implementing that in PHP and maybe a bit of JS.

2. They have removed the builtin sass compiler, which is not necessarily a bad thing, but it also removes the SVG coloring api that I used to change the colour of most of the icons, so a new way of dealing with that is needed. Though they have switched over to using icons which can be coloured using CSS instead, should it's mainly third party apps, and various edge cases that are going to be an issue here. Currently, this is mainly creating workarounds in CSS for inverting icons that are still black.

3. Lastly of course the new design style which the theme needs to be adapted to. This is just purely editing the CSS files or more specifically the Sass files and then compiling them to CSS.

Of course the biggest factor has been a serious lack of time from my side, but the upgrade being quite challenging of course hasn't helped.

Yes, any work on NC25 should go the 25 branch.

If you're interested in taking a look, you're more than welcome to, and if you have some more questions, you're welcome to ask. I hope I at least answered your initial questions, if not, please let me know!

[punkyard]

good luck to you
i'm expecting your release .. NC25 dark theme is absolutely terrible:
can't see a damned thing in there ^^ ✌️

[punkyard]

breeze works with NC25, but as you say it's not ready

[donniewr]

I'm waiting impatiently for the update. I really don't like the NC 25 dark theme too.

Thanks!

[florealcab]

good luck to you i'm expecting your release .. NC25 dark theme is absolutely terrible: can't see a damned thing in there ^^ v

The NC25 dark theme is better than the previews version, and does not appear so horrible in my case, may be you have some extension which cause a bug on switch buttons?

I will give a try on breeze dark NC25 version if it's released one day, but it's good for me.

[mwalbeck]

The Nextcloud 25 version of the theme is now out and should be available in the Nextcloud app store shortly! Please take a look at the release notes, as there are some change to the theme that might affect you!

[natrius]

Just to be sure, the 25.0.0 should work for NC25. Asking, because in the app store i read this:

Server version 24 or lower is required.

[mwalbeck]

Just to be sure, the 25.0.0 should work for NC25. Asking, because in the app store i read this:

Server version 24 or lower is required.

Yes, 25.0.0 is for NC25. Sometimes there can be some oddities with version requirements of apps during the transition phase from one Nextcloud release to the next, so that is probably what you're running into.