Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace login-screen background #283

Closed
WereCatf opened this issue Nov 12, 2021 · 2 comments
Closed

Don't replace login-screen background #283

WereCatf opened this issue Nov 12, 2021 · 2 comments

Comments

@WereCatf
Copy link

If the admin has set up a login-screen background-image, this theme shouldn't be replacing it. It's one thing to theme the login-screen elements, but overriding the background-image is another thing, rendering the option to set one up in the first place useless! Yes, one can fix that with custom CSS, but it's just silly to have to.

If nothing else, simply add a checkbox for "Override login-screen background-image."

@mwalbeck
Copy link
Owner

Hi,

This issue is documented in the README together with two workarounds: https://github.com/mwalbeck/nextcloud-breeze-dark#login-image-not-shown-when-theme-is-enabled

It's an issue that's present if you aren't using pretty URLs. Everything works as intended if you're using pretty URLs.

Yes, one of the workarounds is adding a custom CSS rule, but since the app provides a way to add custom CSS without having to install another app, I don't see it as a big issue. Considering what is needed to add a checkbox specifically for the background image I don't currently see it as a feasible option.

If the two workarounds aren't what you're looking for, then there is also an option to disable theming of the login page entirely. That can be found under the theming settings in Nextcloud.

@mwalbeck
Copy link
Owner

It seems that Nextcloud now handles the redirect properly if you request the custom background image with index.php in the URL while using pretty urls. So I'll be adding index.php to the default URL used for getting custom login screen background in the next release, which means It'll work out of the box with or without pretty urls.

095f650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants