Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a native library, fixes #400 #401

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Provide a native library, fixes #400 #401

merged 1 commit into from
Apr 28, 2021

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Apr 27, 2021

No description provided.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 27, 2021

@gnodet could you please explain what problem is this solving? There is not info in the linked issue either.

@gnodet
Copy link
Contributor Author

gnodet commented Apr 27, 2021

@gnodet could you please explain what problem is this solving? There is not info in the linked issue either.

Recently, I've added some native methods to jansi specifically for mvnd (setenv and chdir). But Jansi has a specific purpose of handling the ansi terminals and it's not supposed to become a location for any kind of native methods.
I've had to add the osx method to get the system memory, so I decided to move them to a more correct location, i.e. inside mvnd.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 27, 2021

Thanks, makes sense!

@gnodet gnodet added this to the 0.5.0 milestone Apr 28, 2021
@gnodet gnodet merged commit c6d32c6 into apache:master Apr 28, 2021
@gnodet gnodet deleted the i400 branch April 28, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants