Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client hangs forever if the daemon crashes #47

Closed
ppalaga opened this issue Jul 30, 2020 · 3 comments
Closed

Client hangs forever if the daemon crashes #47

ppalaga opened this issue Jul 30, 2020 · 3 comments
Assignees
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jul 30, 2020

The daemon may crash for whatever reason, even without calling shutdown hooks. There should be a way for the client to find out that the daemon is down (so that client itself can exit).

@famod
Copy link
Contributor

famod commented Oct 21, 2020

Just a quick thought: The daemon could touch a file periodically and the client could check if the file was touched recently. If not the daemon most likely crashed.

@gnodet
Copy link
Contributor

gnodet commented Oct 21, 2020

Given we have a socket connection, we could simply send a simple keep-alive message from the daemon to the client every second (if nothing has been sent). On the client side, if we haven't received anything since 3 seconds, we consider the daemon crashed.
That's really the same, but it reuses the current socket channel which is already opened.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 21, 2020

we could simply send a simple keep-alive message

Yeah, I also thought of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants