Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom wrapper #455

Closed
Steph0 opened this issue Aug 16, 2021 · 5 comments
Closed

Use custom wrapper #455

Steph0 opened this issue Aug 16, 2021 · 5 comments
Labels
wontfix This will not be worked on

Comments

@Steph0
Copy link

Steph0 commented Aug 16, 2021

Hi there,

First, thanks for the work with mvndaemon.
There is something I can't figure out from the documentation. My project already has a maven wrapper. And i'd like mvndaemon to use my wrapper or at least setup mvndaemon to download the same version that my project uses.

What is the config to do. Note that I installed using sdkman.

If I get the answer here, i'll do a pull request to offer a documentation about it :)

@Steph0
Copy link
Author

Steph0 commented Aug 16, 2021

I saw that: #143
I find that it is a huge missing feature that makes mvnd less interesting to use.
It could be nice at least to have a list of supported maven version (like sdkman) and be able to use this list of supported versions. :)

@ppalaga
Copy link
Contributor

ppalaga commented Aug 17, 2021

A given mvnd version is hardwired to some particular version of Maven core libs. Those are embedded in mvnd's own distro. Mvnd is not using any existing local Maven installation.
To make mvnd use some specific version of Maven core libs, you need to figure out which mvnd version is using your desired Maven core libs version and then stick to that mvnd version.

Of course this does not solve the problem Maven Wrapper solves - i.e. to have a reliable per-repo way of choosing the mvnd version that is known to be suitable for building of the given repo. For that one, having our own mvndw script that would pull a specific version of mvnd (contributions welcome!) still seems to be the most viable solution to me.

@Steph0
Copy link
Author

Steph0 commented Aug 17, 2021

Thanks @ppalaga but how to find the mvnd that contains a given version ? For example i'm searching the one for mvn 3.5.0

The tagging system on the repo does not indicate it

@ppalaga
Copy link
Contributor

ppalaga commented Aug 17, 2021

how to find the mvnd that contains a given version

Only manually in org.mvndaemon.mvnd:mvnd's pom: https://github.com/mvndaemon/mvnd/blob/master/pom.xml#L48

I'm searching the one for mvn 3.5.0

I am afraid the oldest one we ever had in the source tree was 3.6.2 and the oldest release was with 3.6.3

@Steph0
Copy link
Author

Steph0 commented Sep 16, 2021

Forgot to answer due to vacation but thank you for your answers! :)
I think that settles my question

@Steph0 Steph0 closed this as completed Sep 16, 2021
@ppalaga ppalaga added this to the No fix/wont't fix milestone Sep 16, 2021
@gnodet gnodet added the wontfix This will not be worked on label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants