Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorscheme is not always respected #37

Closed
mvllow opened this issue Sep 5, 2022 · 3 comments
Closed

Colorscheme is not always respected #37

mvllow opened this issue Sep 5, 2022 · 3 comments

Comments

@mvllow
Copy link
Owner

mvllow commented Sep 5, 2022

After #36, Rosé Pine theme (dark variant) doesn't use the colorscheme's palette. Light mode works as expected.

Users can pin to tag = v0.2.0 if using a theme that is affected by this.

@fitrh
Copy link
Collaborator

fitrh commented Sep 7, 2022

How to reproduce this bug?

@mvllow
Copy link
Owner Author

mvllow commented Sep 7, 2022

With this config...

use({
	'rose-pine/neovim',
	config = function()
		require('rose-pine').setup()
		vim.cmd('colorscheme rose-pine')
	end,
})
use({
	'mvllow/modes.nvim',
	-- Loading modes after rose-pine is a decent workaround
	-- after = 'rose-pine',
	config = function()
		require('modes').setup()
	end,
})

...Rosé Pine themes modes when the initial background is set to light, e.g. using the dawn variant. When neovim loads with an initial background of dark due to your system theme being in dark mode, Rosé Pine does not completely theme modes.

Manually doing :set background=dark temporarily fixes the issue and properly themes modes.

As mentioned in the code block above, loading modes after the theme fixes this issue, but this workaround wasn't needed before #36. I am unable to pinpoint what exactly caused this issue, though.

Edited to be more concise

@fitrh
Copy link
Collaborator

fitrh commented Sep 8, 2022

Hmm, does calling vim.on_key at the very end of setup did not solve this issue?

@mvllow mvllow closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants