Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit limits don't work #61

Closed
mvf opened this issue Feb 26, 2024 · 2 comments
Closed

Hit limits don't work #61

mvf opened this issue Feb 26, 2024 · 2 comments
Labels
Milestone

Comments

@mvf
Copy link
Owner

mvf commented Feb 26, 2024

Since the removal of the hit limit spin boxes from the toolbar with 185b647, it's been impossible to set per-book and total hit limits. They are fixed at 100 and 1000, respectively. (The hit limits in the options only set the maximum value for the toolbar boxes.)

@mvf mvf added the bug label Feb 26, 2024
@mvf mvf added this to the 2.2.0 milestone Feb 26, 2024
@jameshoggjh90
Copy link

For those who've had this bug during full text searching, I have the latest build running on Windows 10, and as a workaround I've gone into the registry editor to change the values. Make sure all instances of qolibri are closed first (otherwise they'll overwrite the registry again), then go here in the registry editor:

Computer\HKEY_CURRENT_USER\SOFTWARE\qolibri\EpwingViewer

And change the values of:
limit_book
limit_total

Then run qolibri, it should work.

There seems to be another set of values in \EpwingConfigure that equal the options dialog in qolibri, but they're not syncing together. Which is why I think the problem's happening.

Also, those working on the code should be aware that once this bug gets fixed there's another issue: once either the limit total or character total is reached, the program doesn't display the results for some reason.

Thanks.

@mvf mvf closed this as completed in 047fea3 Jul 7, 2024
@mvf
Copy link
Owner Author

mvf commented Jul 7, 2024

once either the limit total or character total is reached, the program doesn't display the results for some reason.

Thanks for pointing this out. Can reproduce, opened #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants