Support smoother completion animation for panning velocity #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've really gotta pull this one down and run it on a device to feel it. |
| @@ -792,10 +802,10 @@ -(void)finishAnimationForPanGestureWithXVelocity:(CGFloat)xVelocity completion:( | |||
| if(self.openSide == MMDrawerSideLeft) { | |||
| CGFloat midPoint = self.maximumLeftDrawerWidth / 2.0; | |||
| if(xVelocity > MMDrawerPanVelocityXAnimationThreshold){ | |||
| [self openDrawerSide:MMDrawerSideLeft animated:YES completion:completion]; | |||
| [self openDrawerSide:MMDrawerSideLeft animated:YES velocity:MAX(ABS(xVelocity),MMDrawerPanVelocityXAnimationThreshold*2) animationOptions:UIViewAnimationOptionCurveEaseOut completion:completion]; | |||
There was a problem hiding this comment.
The velocity passed in here is the same in both places. Just break it out into a new animationVelocity variable and use that in both places.
|
This tiny change makes a marked difference in the panning completion feel. Nice catch! |
|
If you haven't noticed, I've been pushing DRY to really try and get the |
|
Anything else need to go into this one? If not, I'll merge it. |
|
Kittens. Other than that, no. |
kcharwood
added a commit
that referenced
this pull request
May 16, 2013
Merging in. Thanks to @subdigital for reminding me to put this near the top of the queue.
|
Quick turnaround for @subdigital :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are using
UIViewAnimationOptionCurveEaseInOutto complete panning animations, so there is a slight hiccup.We should get smarter and use
UIViewAnimationOptionCurveEaseOutin that state, and let the pan velocity determine how fast it finishes.