-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match on music brainz id when name match fails ? #811
Comments
Similar, but different issue : |
Spotify doesn't supply MB ID so the exact name match is required. Please confirm that the mismatches are only occurring between local media and Spotify? Clearly it is going to be difficult if not impossible to match when Spotify doesn't send the proper artist, track or album name. I have previously spoke to Marcel about matching on a percentage of characters but he has tried that in the past and it resulted in too many false positives. If Marcel is happy to adjust the sort order to ignore case (as per another issue #755) then that will help a little in that similarly named, but different case, situation. Any other ideas from others welcome! |
I consider a mismatch when a file on my system is not matched to an equivalent artist/album/track on spotify yep ... all mismatches I've seen so far were local vs spotify. I'd suggest these options :
|
Some good ideas there. Let's see what @marcelveldt thinks. Note that the tags added by Picard are considered a source of truth so I am pretty sure the least preferred option is "fixing the tags" (unless fixing them is tagging with Picard :-) ) |
Yes and no. If he wants to match his tags with those of his favourite provider then that should be an option. (*) or any other music service ... Plex does something similar by providing users with several sources of meta-data to enrich their media. |
I understand your point. At this time MA attempts to do all the matching work for you to save the user time and effort. However, due to limitations with the metadata supplied from the various music providers it is difficult to achieve a 100% success rate without introducing false positives. Your idea to be able to manually link is a good one but will be a feature enhancement. On the UTF encoding Marcel accepted that as a bug on Discord so I will add that label as well. |
manually matching is definitely a 'nice to have' feature for a future that will make life easier, especially for users who don't have a (local) filesystem source that can be updated by re-tagging a few files. |
implemented a fix in version 2022.8.2, can you confirm that works ? |
Hi @DutchJaFO . The case insensitive sorting has been implemented. Marcel also believes he has implemented your suggestion #3 above and utf encoding shouldn't matter because MA only compares ascii characters now. Manual matching is something that will be looked at once the auto logic is perfected. On that basis we will close this issue soon unless you have further problems. Thanks! P.S. Do refresh your database after updating |
What version of Music Assistant has the issue?
2022.8.1
The problem
I found two duplicate artist entries in my library :
= Salt-N-Pepa
= "Weird" Al Yankovic
How to reproduce
Both names looked identical, but looking more closely I noticed that "Weird" Al Yankovic had two variants :
= One with 'standard' double quotation marks showing the spotify tracks/albums : "Weird Al" Yankovic
= One with fancy double quotation marks showing the local file system tracks : “Weird Al” Yankovic
The local filesystem files had been updated with info from Music Brainz Picard with UTF-16 encoding.
The Salt-N-Pepa situation was fixed by
I did try a force resync in MA to fix the situation, but that didn't appear to solve it.
As such I had to go nuclear (disable MA integration, remove the musicassistant.db file from system, enable MA integration).
This did
Relevant log output
No response
Additional information
Music Brainz Picard was set to use ID3 v2.3 UTF-16
Spotify may be using UTF-8 character set, which can explain multiple versions tracks from various sources that appear identical to the user in the MA library.
Possibly related :
Track names on spotify don't appear to match the ones in music brainz either.
Salt-N-Pepa debut album "A Salt with a deadly Pepa" has track in music brainz listed as "Shake Your Thang" while Spotify lists it as "Shake Your Thang (It's Your Thing)" which don't match based on track name for obvious reasons.
I suspect that this mismatch in track/album/artist names between spotify (streaming service) and music brainz data may also cause several other tracks, albums and artists not to be matched in MA library.
Suggestion :
If spotify (or any other service) has the music brainz Id's available this should make matching artists, albums and tracks easier.
What version of Home Assistant Core are your running
2022.8.1
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)
The text was updated successfully, but these errors were encountered: