Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Part issues (slash symbols should not trigger any issue) #14477

Closed
DmitryArefiev opened this issue Nov 11, 2022 · 6 comments · Fixed by #20210
Closed

Renaming Part issues (slash symbols should not trigger any issue) #14477

DmitryArefiev opened this issue Nov 11, 2022 · 6 comments · Fixed by #20210
Assignees
Labels
P1 Priority: High

Comments

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Nov 11, 2022

Some algorithms were implemented in #14288 #14290.

The current issue collects all other problems.

  1. Some special symbols should be filtered since the cause problems with saving files: <>:/“|?*

THIS BEHAVIOR WAS CHANGED IN #20210 AND SPECIAL SYMBOL ARE ALLOWED IN PART NAMES BUT IT DOESN'T TRIGGER ANY ISSUE BECAUSE OF SAFE IMPLEMENTATION (THAT'S THE FIX)

bandicam.2022-11-11.15-07-10-999.mp4
  1. [THIS IS FIXED in duplicated_parts_fix #18999] When renaming parts, the filter mechanism should not be case sensitive. I.e. it should not allow to create Violin and violin
    This is important for Uncompressed MuseScore folder format

  2. [THIS IS LOGGED SEPARATELY When renaming part, it should allow to create more than one SPACE in name. #20408 ] When renaming part, it should allow to create more than one SPACE in name

bandicam.2022-11-11.15-09-26-315.mp4

Platform information
macOS, Windows, Linux

Additional context
#16127 #14288 #14290

@DmitryArefiev DmitryArefiev added the P2 Priority: Medium label Nov 11, 2022
@DmitryArefiev
Copy link
Contributor Author

@RomanPudashkin There is also case sensitive issue with workspace name

bandicam.2022-11-11.15-26-47-995.mp4

@DmitryArefiev
Copy link
Contributor Author

The current issue collects all other problems.

  1. Some special symbols should be filtered since the cause problems with saving files:

<>:/“|?*

Using slash symbol (/) probably is most dangerous (see #19054)

@DmitryArefiev DmitryArefiev added P1 Priority: High and removed P2 Priority: Medium labels Aug 14, 2023
@github-project-automation github-project-automation bot moved this to To triage in MuseScore 4.2 Aug 14, 2023
@bkunda
Copy link

bkunda commented Aug 18, 2023

@RomanPudashkin I thought a fix for this was addressed here? #14290

But certainly it seems it is still possible to enter "excluded" characters in 4.1.1.

@DmitryArefiev
Copy link
Contributor Author

See #16127 how slash symbols are dangerous

@DmitryArefiev DmitryArefiev changed the title [MU4 Issue] Renaming Parts issues [MU4 Issue] Renaming Part issues (slash symbols should not be allowed) Sep 1, 2023
@DmitryArefiev DmitryArefiev changed the title [MU4 Issue] Renaming Part issues (slash symbols should not be allowed) Renaming Part issues (slash symbols should not be allowed) Sep 6, 2023
@bkunda
Copy link

bkunda commented Sep 15, 2023

@cbjeukendrup just confirming whether you are still pursuing a fix for this?

@cbjeukendrup
Copy link
Contributor

Yes! This is one of the next things I'll do.

@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore 4.2 Dec 11, 2023
@DmitryArefiev DmitryArefiev moved this from Done to Needs porting in MuseScore 4.2 Dec 11, 2023
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore 4.2 Dec 11, 2023
@DmitryArefiev DmitryArefiev changed the title Renaming Part issues (slash symbols should not be allowed) Renaming Part issues (slash symbols should not trigger any issue) Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants