feat: share image directly via share menu item #35
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,17 @@ | |
| import android.app.DownloadManager; | ||
| import android.content.Context; | ||
| import android.content.Intent; | ||
| import android.content.pm.PackageManager; | ||
| import android.database.Cursor; | ||
| import android.graphics.Bitmap; | ||
| import android.net.Uri; | ||
| import android.os.AsyncTask; | ||
| import android.os.Bundle; | ||
| import android.os.Environment; | ||
| import android.support.v4.app.ActivityCompat; | ||
| import android.support.v4.app.LoaderManager; | ||
| import android.support.v4.content.CursorLoader; | ||
| import android.support.v4.content.FileProvider; | ||
| import android.support.v4.content.Loader; | ||
| import android.support.v4.view.MenuItemCompat; | ||
| import android.support.v7.widget.ShareActionProvider; | ||
|
|
@@ -45,6 +51,11 @@ | |
| import com.squareup.picasso.Callback; | ||
| import com.squareup.picasso.Picasso; | ||
|
|
||
| import java.io.ByteArrayOutputStream; | ||
| import java.io.File; | ||
| import java.io.FileOutputStream; | ||
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * A fragment representing a single subject. | ||
| * This fragment is either contained in a {@link ListActivity} | ||
|
|
@@ -427,7 +438,63 @@ private void updateShareActionIntent() { | |
| //shareIntent.putExtra(Intent.EXTRA_STREAM, mUriImageStandard); | ||
| //shareIntent.setType("image/*"); | ||
|
|
||
| if (mUriStandardRemote!=null) { | ||
| GetImageBitmapAsyncTask getImageBitmapAsyncTask = new GetImageBitmapAsyncTask(){ | ||
| @Override | ||
| protected void onPostExecute(Uri uri) { | ||
| shareIntent.setType("image/*"); | ||
| shareIntent.putExtra(Intent.EXTRA_STREAM, uri); | ||
| shareIntent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION); | ||
| mShareActionProvider.setShareIntent(shareIntent); | ||
| } | ||
| }; | ||
| getImageBitmapAsyncTask.execute(mUriStandardRemote); | ||
| } | ||
|
|
||
|
|
||
| mShareActionProvider.setShareIntent(shareIntent); | ||
|
There was a problem hiding this comment. Do we still need this (now second) setShareIntent()? Maybe the whole instantiation of the shareIntent should move into onPostExecute()? There was a problem hiding this comment. The second setShareIntent is set after the AsyncTask has started executing, but before it is completed. When the AsyncTask completes, the share intent is updated with the image type and content URI. I had left it there to provide a temporary intent on slower devices or in edge cases where the AsyncTask doesn't complete before the user decides to share, but it can indeed be removed. I will remove it in the next commit. I would still leave the instantiation outside onPostExecute, since that leaves less main thread work to be done after the AsyncTask is completed. There was a problem hiding this comment.
OK. That sounds reasonable, but it would be nice to have a comment explaining that choice. |
||
| } | ||
|
|
||
| private static final int REQUEST_EXTERNAL_STORAGE = 1; | ||
| private static String[] PERMISSIONS_STORAGE = { | ||
|
There was a problem hiding this comment. Can you use the constants here instead of hard-coding these strings? This seems to be suitable: https://developer.android.com/reference/android/Manifest.permission.html#WRITE_EXTERNAL_STORAGE |
||
| "android.permission.WRITE_EXTERNAL_STORAGE", | ||
| "android.permission.READ_EXTERNAL_STORAGE" | ||
| }; | ||
|
|
||
| public static void verifyStoragePermissions(Activity activity) { | ||
| int permission = ActivityCompat.checkSelfPermission(activity, "android.permission.WRITE_EXTERNAL_STORAGE"); | ||
|
|
||
| if (permission != PackageManager.PERMISSION_GRANTED) { | ||
| ActivityCompat.requestPermissions( | ||
| activity, | ||
| PERMISSIONS_STORAGE, | ||
| REQUEST_EXTERNAL_STORAGE | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| private class GetImageBitmapAsyncTask extends AsyncTask<String,Integer,Uri> { | ||
|
There was a problem hiding this comment. spaces after the commas would be nice. There was a problem hiding this comment. Absolutely, I have added spaces |
||
| @Override | ||
| protected Uri doInBackground(String... params) { | ||
| try { | ||
| Bitmap image = Picasso.with(getContext()).load(params[0]).get(); | ||
| ByteArrayOutputStream bytes = new ByteArrayOutputStream(); | ||
| image.compress(Bitmap.CompressFormat.JPEG, 100, bytes); | ||
|
|
||
| //TODO: PROVIDE A MORE DESCRIPTIVE FILENAME HERE IF PLAUSIBLE. Filename will be visible when sharing via certain apps like Gmail etc. | ||
| String filename = "galaxy_zoo_image.jpg"; | ||
|
|
||
| String pathname = Environment.getExternalStorageDirectory() + File.separator + filename; | ||
| File f = new File(pathname); | ||
| f.createNewFile(); | ||
| FileOutputStream fo = new FileOutputStream(f); | ||
| fo.write(bytes.toByteArray()); | ||
| return FileProvider.getUriForFile(getActivity(), getString(R.string.authority_fileprovider), f); | ||
| } catch (IOException e) { | ||
| verifyStoragePermissions(getActivity()); | ||
| e.printStackTrace(); | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove these .iml file changes from the commit? I do update them every now and then, but I try not to pollute the real changes with these changes to generated files.