Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform support #174

Merged
merged 45 commits into from
Jun 6, 2021
Merged

Multiplatform support #174

merged 45 commits into from
Jun 6, 2021

Conversation

rpls
Copy link
Contributor

@rpls rpls commented Dec 27, 2020

This PR will add support for multiple platforms, similar to how PQM3 does.

  • Adapt the PQM3 build system
  • Add support for the discovery board
  • Add support for the Nucleo-L476G
  • Add support for the CW308-F3 board
  • Add support for the Nucleo-L4R5ZI
  • Add support for some non-STM32 platform.
  • Adapt the python scripts to use the new build system
  • Adapt the evaluation scripts to support multiple platforms
  • Write README.md

Depends on the PR mupq/mupq#57 of the mupq repo

@rpls
Copy link
Contributor Author

rpls commented Dec 28, 2020

Adapting the new build system will take some work in the mupq repo as well. The new build system is able to build a library per scheme implementation, so the mupq python script doesn't need to bother with it for the size benchmarks. Also I'll abstract the Platform Class a bit more. Right now, the only the run method is used anyway, so I'll make this an abstract method and the platform interface will have to bother with "Run binary X on platform and get output".

@rpls
Copy link
Contributor Author

rpls commented Dec 28, 2020

@Ko- and @mkannwischer you can start reviewing this. The stm32f4discovery platform should work as expected.

@rpls rpls requested a review from mkannwischer December 29, 2020 13:39
@mkannwischer
Copy link
Contributor

Thanks, @rpls!
Looks good to me and works nicely for me on the F407.
You may want to rebase on top of #173.

@rpls rpls force-pushed the multiplatform branch 2 times, most recently from ef0cad1 to b2d1576 Compare January 17, 2021 01:33
@rpls rpls marked this pull request as ready for review February 21, 2021 21:59
@rpls rpls changed the title WIP: Multiplatform support Multiplatform support Feb 21, 2021
@rpls
Copy link
Contributor Author

rpls commented Jun 6, 2021

Everything is up to date and I also posted benchmarks now.

@mkannwischer
Copy link
Contributor

Thanks @rpls for all the work.
This looks good to me now!

@mkannwischer mkannwischer merged commit 12d5e56 into master Jun 6, 2021
@mkannwischer mkannwischer deleted the multiplatform branch June 6, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants