Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check js dependencies #924

Open
luchotc opened this issue Feb 1, 2018 · 3 comments
Open

Check js dependencies #924

luchotc opened this issue Feb 1, 2018 · 3 comments
Labels

Comments

@luchotc
Copy link
Contributor

luchotc commented Feb 1, 2018

Webcomponents.js was introduced and its loaded from vendor folder. It would be better to include it as a rails-asset.
Also check if rails-ujs is still needed as it is now part of Rails core since 5.1.0

@afska
Copy link
Collaborator

afska commented Sep 13, 2018

@luchotc I don't know if I am understanding this issue. I read this docs page and the vendor/ directory is still the recommended method to include third party plugins. I tried searching what a 'rails asset' is, but I always end up in docs about the assets pipeline. Could you send me a link with more info?

@afska afska added paused and removed ready labels Sep 14, 2018
@flbulgarelli
Copy link
Member

@luchotc ?

@luchotc
Copy link
Contributor Author

luchotc commented Sep 21, 2018

I think the first part of the issue was written by request of @flbulgarelli. The original intention was to avoid including the js manually and use a depency instead, like polymer-rails or such. Since we are coupled to that specific version of webcomponents i don't think it's worth.

Also check if rails-ujs is still needed as it is now part of Rails core since 5.1.0

This one although, may be worth checking

PS: sorry for the delay @rodri042, i was AFK 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants