-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple upload support #712
Comments
A quick solution for this could be a multiuploader that just concatenates all the files using some kind of separator. For instance: /**** A.java ****/
public class A {
private int field;
public int getField() {
return this.field;
}
}
/**** B.java ****/
public class B {
public String shout(String something) {
return something.toUpperCase();
}
} |
Yeah, I was actually thinking the same 😄 |
Related to mumuki/mumuki-java-runner#5 |
Ok. Any suggestions about the separators? |
I'd try to use something that can not lead to ambiguities and that is very unlikely to be entered by a user. /*@@@ B.java @@@*/ We could use "#{open_comment}@@@ #{filename}.#{extension} @@@#{close_comment} |
Agree. Should this feature be configurable or automatically available for every exercise with upload editor type? |
I am not sure. I think we could enable this feature to every exercise, not only upload exercises. Or perhaps we could flag some exercises as multi-editable, to enable this behavior. See #711. This is a rough spec:
|
Seems nice, but right now I only have time to develop part 2, the one related to the upload editor; and I really want to use this feature in about a month, on exercises with manual correction. Can we proceed with that and let the multi-editor discussion for another time? |
Sure! |
Great. Do you think the zip file is necessary? Any advantages over a plain old |
I think that using a file is easier if you want to provide a small script to upload it automatically to the web, like course does. But your proposal works for me. |
It would be nice that the solution upload support also one the following use cases:
The text was updated successfully, but these errors were encountered: