Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gutter icon in code mirror to display line error #1255

Open
aguspina opened this issue Nov 27, 2017 · 4 comments
Open

Add gutter icon in code mirror to display line error #1255

aguspina opened this issue Nov 27, 2017 · 4 comments

Comments

@aguspina
Copy link
Contributor

We need to add the error line number in the mumukit output, so as to give laboratory the necessary info to add a gutter icon in the corresponding line.

@flbulgarelli
Copy link
Member

Hay que cambiar mumukit para que agregue a la salida inline_messages:

{
  
   exit: ...
   result: ...
   test_results: ....
   type: ....
   inline_messages: [
      { type: 'error',  message: 'ups aca esto no compila', line: 2, column: 4 },
      { type: 'warning',  }
   ]
}

Hay que revisar Bridge (tenemos que ver si es necesario cambiar algo).

Hay que cambiar labo: para que trabaje con esta salida.

Hay que cambiar algún runner (por ejemplo, el de java) para que reporte esta información.

  • puede que necesitemos otro hook
  • puede que lo agregemos en el feedback hook
  • puede que introduzcamos la idea de un observador del request

@flbulgarelli flbulgarelli transferred this issue from mumuki/mumuki-platform Dec 4, 2018
@fedescarpa fedescarpa removed their assignment Aug 27, 2019
@fedescarpa
Copy link
Member

fedescarpa commented Aug 27, 2019

@flbulgarelli, does this issue still make sense?

@flbulgarelli
Copy link
Member

Sip.

@flbulgarelli
Copy link
Member

Últimamente yo trabajo mucho más con bloques pero cuando trabajas con texto es muy difícil encontrar errores con tan poca información contextual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants