Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo 4.0 -- Problem with FmFileIOAccessor default createDirectory: dirString. #2

Open
hhzl opened this issue Aug 28, 2015 · 5 comments

Comments

@hhzl
Copy link

hhzl commented Aug 28, 2015

pharo4 0_fileman_tests_screenshot from 2015-08-28 11 48 44

pharo4 0_fileman_testdirectoryexists_screenshot from 2015-08-28 11 49 50

        FmFileIOAccessor default createDirectory: dirString.

calls

       createDirectory: fullPathName
^self primCreateDirectory: fullPathName asVmPathName

and this causes an error

      primCreateDirectory: fullPath
"Create a directory named by the given path. Fail if the path is bad or if a file or directory by that name already exists."

<primitive: 'primitiveDirectoryCreate' module: 'FilePlugin'>
self primitiveFailed
@mumez
Copy link
Owner

mumez commented Aug 28, 2015

I added FmFileSystemFileIOAccessor>>createDirectory:. Since it uses FileSystem API, it does not raise primitive error anymore. Please check it.
43c6507

@hhzl
Copy link
Author

hhzl commented Aug 28, 2015

fileman_pharo4 0_screenshot from 2015-08-28 14 00 32

@mumez
Copy link
Owner

mumez commented Aug 28, 2015

Hmm.. Not sure what is going on...
I've tested on Windows and results were all green.

(linear load : 
    linear load : 0.4.1 [ConfigurationOfFileMan]
        load : FileMan-Core-MasashiUmezawa.17
        load : FileMan-Squeak-mu.3
        load : FileMan-Adaptor-FileSystem-MasashiUmezawa.7
        load : FileMan-Example-mu.1
        load : FileMan-Test-mu.3)

0 4 1_test_results

@hhzl
Copy link
Author

hhzl commented Aug 28, 2015

Retest on MSWindows 7

Steps
0. Download Pharo 4.0 for MSWindows

  1. Open Monticello Browser
  2. Click on +Repository
  3. Choose filetree://
  4. Folder FileMan -> repository folder
  5. Click on ConfigurationOfFileMan.package
  6. Click on Load
  7. In a Playground: ConfigurationOfFileMan load
  8. TestRunner --> FileMan-Test

Result

fileman-tests

@hhzl
Copy link
Author

hhzl commented Aug 28, 2015

Retest on Linux Mint

fileman_test_linux_mint_screenshot from 2015-08-28 22 55 53

Problem in testDefaultDirectory

The path is duplicated.

/home/user/pharo4.0/shared/home/user/pharo4.0/shared

fileman_test_on_linuxmint_testdefaultdirectory_screenshot from 2015-08-28 23 00 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants