Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Proposal to add Prettier to the project. #321

Open
amin-xiv opened this issue Nov 7, 2024 · 14 comments · May be fixed by #347
Open

[Website] Proposal to add Prettier to the project. #321

amin-xiv opened this issue Nov 7, 2024 · 14 comments · May be fixed by #347
Assignees

Comments

@amin-xiv
Copy link
Contributor

amin-xiv commented Nov 7, 2024

Here are the values:
printWidth : (doubt: it should be the number of characters per line right?)
tabWidth : 4
useTabs : true
bracketSpacing : false
arrowPens : true
trailingComma : false

@github-actions github-actions bot added the Review Queued Waiting for the Dataverse's Maintainer to review this issue. label Nov 7, 2024
@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 9, 2024

@multiverseweb Any thoughts about this? 😊

@multiverseweb
Copy link
Owner

multiverseweb commented Nov 9, 2024

Okay @amin-xiv, make sure it doesn't affect the functionality of the code. Also, will it run for all files or only for python?

@multiverseweb
Copy link
Owner

Here are the values:
printWidth : (doubt: it should be the number of characters per line right?)
tabWidth : 4
useTabs : true
bracketSpacing : false
arrowPens : true
trailingComma : false

@amin-xiv I accidentally edited your comment instead of quoting a reply 🥲

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 9, 2024

@multiverseweb 1/No it doesn't affect the functionality. 2/Prettier doesn't work for python, it works for JS, TS, CSS, HTML, markdown, YAML and JSON. It simply arranges the code, according to your configuration, you can define the variables that was stated above. Thank you.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 9, 2024

@multiverseweb And yes printWidth, are the characters per line that require the extension to automatically wrap the rest of the text to the next line.

@multiverseweb
Copy link
Owner

@multiverseweb And yes printWidth, are the characters per line that require the extension to automatically wrap the rest of the text to the next line.

Okay @amin-xiv go ahead. Set the appropriate value of printWidth yourself, assigned.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 9, 2024

@multiverseweb Thank you very much sir.

@multiverseweb multiverseweb removed the Review Queued Waiting for the Dataverse's Maintainer to review this issue. label Nov 9, 2024
@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 9, 2024

@multiverseweb Sorry, but what about singleQuote , if it is set to true, it will change every double quote to single, and when it is false, it will do the opposite.
Note: this setting doesn't affect template strings or HTML attributes or JSON strings.

@multiverseweb
Copy link
Owner

@multiverseweb Sorry, but what about singleQuote , if it is set to true, it will change every double quote to singe, and when it is false, it will do the opposite.
Note: this setting doesn't affect template strings or HTML attributes.

Set it to false.

@amin-xiv
Copy link
Contributor Author

@multiverseweb So far I have added it to the project, what is only remaining is to update the README.md file.

@multiverseweb
Copy link
Owner

@amin-xiv nice, I would like to know what changes are required in the README.md file?

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 10, 2024

@multiverseweb In order to allow prettier:
1/The prettier extension must be installed, so that will be included.
2/In order for it to work, correctly, with the correct version and settings, the node_modules/ folder has to be installed, so I will just add after you clone the repository in the README file, simply run npm install which is going to install all the dependencies required for it to work across al users. I added the node_modules/ to the .gitignore folder because it can add unnecessary space, and the user only needs the package.json and the package-lock.json folders in order to install it, so they will be included.

In conclusion, what will be added to the README file are going to be some few additions in the section of Prerequisites in order to set it up correctly.

@multiverseweb
Copy link
Owner

multiverseweb commented Nov 10, 2024

Okay @amin-xiv. In a few days from now I'll be fixing the structure of the repo and automating the process of project set-up. For this, I'll add a file requirements.txt which will include all the modules that need to be installed before using the software.
You can continue with the steps you've mentioned.

@amin-xiv
Copy link
Contributor Author

@multiverseweb Okay, Thanks.

This was referenced Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants