Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Add better error handling around connection pulls (Already Piped, etc) #43

Closed
jacobheun opened this issue Jul 17, 2018 · 2 comments
Closed

Add better error handling around connection pulls (Already Piped, etc) #43

jacobheun opened this issue Jul 17, 2018 · 2 comments
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@jacobheun
Copy link
Contributor

Errors are often popping up around https://github.com/multiformats/js-multistream-select/blob/master/src/dialer/index.js#L47. We need to ensure that we are catching errors at this level so that they can be passed up the callback chain instead of ending up as Uncaught Errors.

References:
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important labels Jul 17, 2018
@jacobheun
Copy link
Contributor Author

Catch already piped errors on dialer.handle #44

@daviddias daviddias added the status/ready Ready to be worked label Aug 25, 2018
@jacobheun
Copy link
Contributor Author

This is stale as of the 0.15 refactor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @daviddias