Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

feat: validation. fixes #43 #44

Merged
merged 3 commits into from
Apr 10, 2019
Merged

feat: validation. fixes #43 #44

merged 3 commits into from
Apr 10, 2019

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Apr 7, 2019

Simple algorithm agnostic validation w/ tests.

@mikeal mikeal requested review from vmx and hugomrdias April 7, 2019 21:55
@ghost ghost assigned mikeal Apr 7, 2019
@ghost ghost added the status/in-progress In progress label Apr 7, 2019
hugomrdias
hugomrdias suggested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeal can we get the linter happy ? the rest LGTM

vmx
vmx reviewed Apr 8, 2019
View reviewed changes
test/index.spec.js Show resolved Hide resolved
test/index.spec.js Outdated Show resolved Hide resolved
test/index.spec.js Outdated Show resolved Hide resolved
@mikeal
Copy link
Contributor Author

mikeal commented Apr 8, 2019

@hugomrdias fixed. we should add npm run lint to pretest cause I had no idea these were failing since I just run the standard npm test before checkin.

@mikeal
Copy link
Contributor Author

mikeal commented Apr 10, 2019 •
edited
Loading

aegir lint —fix appears to be very broken. It ends up suppressing errors that can be fixed but not actually fixing any of the issues in the files. Lint issues should be fixed now for real.

@mikeal mikeal requested a review from hugomrdias April 10, 2019 20:31
@hugomrdias hugomrdias merged commit fc01b26 into master Apr 10, 2019
@ghost ghost removed the status/in-progress In progress label Apr 10, 2019
@hugomrdias hugomrdias deleted the validate branch April 10, 2019 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vmx vmx vmx left review comments

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees

@mikeal mikeal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeal @vmx @hugomrdias