-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported DNS format seems wonky #40
Comments
IMO, addresses like |
I also agree that that address should not fall under the |
Yes, https://github.com/multiformats/js-mafmt/blob/v6.0.7/src/index.js#L25, should just go away. It's already covered in |
I will move that out then |
Is there a reason DNS addresses are only supported on TCP? It seems they should be supported with other protocols, right? |
This is what I ended up doing: multiformats/go-multiaddr-fmt@53297ec |
I agree and will add it here!
Thanks for the heads up, I will remove it! |
Fixed in #42 |
The exported DNS format allows for TCP encapsulation, which is weird: https://github.com/multiformats/js-mafmt/blob/master/src/index.js#L25
It was introduced in this PR: #14
The text was updated successfully, but these errors were encountered: