Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store as a string internally #57

Closed
Stebalien opened this issue Oct 19, 2017 · 1 comment
Closed

Store as a string internally #57

Stebalien opened this issue Oct 19, 2017 · 1 comment

Comments

@Stebalien
Copy link
Member

This would ~half memory usage of our peerstore. Currently, we store every multiaddr twice.
@Stebalien
Copy link
Member Author

Additional motivation: We already copy multiaddrs when Bytes() is called to ensure that they're immutable. If we use strings, we could store them in DHT messages as strings. This would help with what looks to be the primary source of slice allocation load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien