Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusions .gitignore should not be excluded #460

Closed
holiday-sunrise opened this issue Apr 1, 2021 · 4 comments · Fixed by #474
Closed

Exclusions .gitignore should not be excluded #460

holiday-sunrise opened this issue Apr 1, 2021 · 4 comments · Fixed by #474

Comments

@holiday-sunrise
Copy link
Contributor

holiday-sunrise commented Apr 1, 2021

The class CopyFileVisitor uses the Exclusions Enumeration.

There is a exclusion for

GIT(File.separator + ".gitignore"),

this should be removed

And add catalog exlusion

@mlischetti mlischetti linked a pull request Jul 8, 2021 that will close this issue
@mlischetti
Copy link
Contributor

We've added .gitignore file into exclusions because even copying this file from mule 3 project some changes has to be done to add needed exclusions by Studio 7

@holiday-sunrise
Copy link
Contributor Author

which changes ? if you migrate the api inside a devops there have to be a .gitignore file !!!

@holiday-sunrise
Copy link
Contributor Author

maybe we can create a post migraten step "CreateIrnoreFile" a new .gitignore file will be created "Studio 7" dependend

@holiday-sunrise holiday-sunrise changed the title Exclusions .gitignore should not be excluded Exclusions .gitignore should not be excluded and add catalog exlusion Jul 15, 2021
@afelisatti
Copy link

Yes, thanks, @holiday-sunrise. We are evaluating options here. Ideally, we believe the tool should merge the new Studio 7 requirements with any existing data in the file. Since this could take some time to implement, we think an option to preserve the file could help in the meantime. What do you think?

@afelisatti afelisatti changed the title Exclusions .gitignore should not be excluded and add catalog exlusion Exclusions .gitignore should not be excluded Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants