-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add a new section for Integration #4411
Conversation
@bharatkashyap Not sure why Netlify preview fails. Can you have a look? |
Instead of a root level section, can we make it a sub-section of the Introduction? I think that makes more sense in the hierarchy of the navigation, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Vale changes in my own copy :D
Also why did we remove the numbers from the headings?
In the React Router guide I sometimes mention "step 1" or "step 3" but this way it doesn't make sense anymore, we'd have to change it.
Based on the core docs Integration section, I removed the numbers. There were two mentions of step 1, step 2 which I have now tackled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Prakhar!
We should have also added new redirect rules to the @prakhargupta1 Can you take this up? I'll redeploy the docs once this is merged |
Oh sorry, completely missed it. Thanks for pointing it out! PR: #4475 |
Preview: https://deploy-preview-4411--mui-toolpad-docs.netlify.app/toolpad/core/integrations/nextjs-approuter/