Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][examples] Featured example review #4506

Closed
prakhargupta1 opened this issue Dec 4, 2024 · 1 comment · Fixed by #4517
Closed

[core][examples] Featured example review #4506

prakhargupta1 opened this issue Dec 4, 2024 · 1 comment · Fixed by #4517
Labels
docs Improvements or additions to the documentation examples Relating to /examples

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Dec 4, 2024 •
edited
Loading

Based on my discussion of mui/material-ui#44415 with Olivier:

  • In the featured example, only 'See live preview' is clickable, while in the Material UI templates, clicking anywhere on the preview works.

  • While checking the source code of the featured example, it also came up that with Next 15, there should be React 19.
@prakhargupta1 prakhargupta1 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer docs Improvements or additions to the documentation examples Relating to /examples and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 4, 2024
@bharatkashyap bharatkashyap mentioned this issue Dec 6, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Upgrade featured example to React 19 bharatkashyap/mui-toolpad
1 participant
@prakhargupta1