[TreeView] Clean label editing code #14264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
8e3ea4f
to
4484573
Compare
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
4484573
to
cdab9e0
Compare
|
Deploy preview: https://deploy-preview-14264--material-ui-x.netlify.app/ |
flaviendelangle
commented
Aug 19, 2024
| @@ -1,8 +1,12 @@ | |||
| export interface TreeItem2LabelInputProps extends React.InputHTMLAttributes<HTMLInputElement> { | |||
There was a problem hiding this comment.
We should avoid to add props we don't actually use to the typing of our slots.
That way people implementing custom slots only need to support the props we actually need and not all the props we could theoretically use on our default slot component.
| UseTreeViewLabelSignature, | ||
| } from './useTreeViewLabel.types'; | ||
|
|
||
| export const isAndroid = () => navigator.userAgent.toLowerCase().includes('android'); |
| @@ -76,5 +76,10 @@ export type UseTreeViewLabelSignature = TreeViewPluginSignature<{ | |||
| experimentalFeatures: 'labelEditing'; | |||
| dependencies: [UseTreeViewItemsSignature]; | |||
| }>; | |||
| export interface UseTreeItem2LabelInputSlotPropsFromItemsReordering | |||
There was a problem hiding this comment.
Typo in the name and the props were never added to the typing of UseTreeItem2LabelInputSlotProps
| const editable = instance.isItemEditable(itemId); | ||
|
|
||
| if (!editable) { | ||
| return {}; | ||
| } | ||
|
|
||
| const handleKeydown = ( |
There was a problem hiding this comment.
Move those two callbacks here, that way useTreeItem2 is totally agnostic of anything regarding this prop
We have some infos about label editing in other slots but nothing too important
flaviendelangle
changed the title
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
e883c8a
to
5070e7d
Compare
noraleonte
approved these changes
Aug 21, 2024
packages/x-tree-view/src/TreeItem2LabelInput/TreeItem2LabelInput.types.ts
Outdated
Show resolved
Hide resolved
This was referenced Sep 27, 2024
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.