From 14bf9c44a3d385cefd67703c260955051fa1435c Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 7 Jan 2024 20:21:31 +0100 Subject: [PATCH] [core] Since Playwright v1.38.0, it does not download browsers automatically --- .circleci/config.yml | 2 -- .github/workflows/l10n.yml | 3 --- netlify.toml | 2 -- package.json | 2 +- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index efc5d1c991ea5..c7f4b1b098366 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -88,8 +88,6 @@ commands: - run: name: Install js dependencies command: yarn install - environment: - PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: <<# parameters.browsers >>0<><<^ parameters.browsers >>1<> - when: condition: << parameters.browsers >> steps: diff --git a/.github/workflows/l10n.yml b/.github/workflows/l10n.yml index 38e190c28e9bc..49e1151456089 100644 --- a/.github/workflows/l10n.yml +++ b/.github/workflows/l10n.yml @@ -24,9 +24,6 @@ jobs: node-version: 18 cache: 'yarn' # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies - run: yarn install - env: - # Don't need playwright in this job - PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 - name: yarn l10n --report env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/netlify.toml b/netlify.toml index 5a7533e06795b..5666dd591fc97 100644 --- a/netlify.toml +++ b/netlify.toml @@ -10,8 +10,6 @@ [build.environment] NODE_VERSION = "18" NODE_OPTIONS = "--max_old_space_size=4096" - # Not using `playwright` when building docs. - PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD = "1" [[plugins]] package = "./node_modules/@mui/monorepo/packages/netlify-plugin-cache-docs" diff --git a/package.json b/package.json index 6becf739353b8..98cfe83553a3d 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "typescript": "lerna run --no-bail --parallel typescript", "typescript:ci": "lerna run --concurrency 3 --no-bail --no-sort typescript", "build:codesandbox": "yarn release:build", - "install:codesandbox": "PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 yarn install --ignore-engines", + "install:codesandbox": "yarn install --ignore-engines", "release:changelog": "node scripts/releaseChangelog.mjs", "release:version": "lerna version --exact --no-changelog --no-push --no-git-tag-version --no-private", "release:build": "lerna run --parallel --no-private --scope \"@mui/*\" build",