[data grid] Using rowSelectionPropagation and rowSelectionModel at the same time cause a crash

[GabrielVooDB]

Steps to reproduce

Steps:

1. Open this link to live example: https://codesandbox.io/p/sandbox/selectionpropagation-and-selectionmodel-issue-svqxrm
2. Wait a few seconds for the grid to crash

Current behavior

Initially, while our data is loading, we provide an empty rows array to the Grid. As soon as the data is received and the final rows array is created and provided to the Grid, a crash occurs.

Providing the "isLoading" flag to the Grid does not prevent the issue from happening.

A workaround is to wait a render frame before providing the rowSelectionModel to the grid, after the final rows array has been provided to the Grid.

Expected behavior

The grid should not crash.

Context

We were trying to have both row grouping with row propagation and row model selection to allow the user to select rows and do operations on them with an action menu.

Your environment

npx @mui/envinfo

  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: rowSelectionPropagation rowSelectionModel row grouping
Order ID: 100223

[michelengelen]

@GabrielVooDB thanks for opening this. It is definitely a bug and can be fixed with a very simple change:

--- a/packages/x-data-grid/src/hooks/features/rowSelection/useGridRowSelection.ts
+++ b/packages/x-data-grid/src/hooks/features/rowSelection/useGridRowSelection.ts
@@ -484,7 +484,7 @@ export const useGridRowSelection = (
           return;
         }
         const node = tree[id];
-        if (node.type === 'group') {
+        if (node?.type === 'group') {
           const isAutoGenerated = (node as GridGroupNode).isAutoGenerated;
           if (isAutoGenerated) {
             delete selectionLookup[id];

I will open a PR in a minute! 👍🏼

[michelengelen]

@GabrielVooDB thanks for opening this. It is definitely a bug and can be fixed with a very simple change:

--- a/packages/x-data-grid/src/hooks/features/rowSelection/useGridRowSelection.ts
+++ b/packages/x-data-grid/src/hooks/features/rowSelection/useGridRowSelection.ts
@@ -484,7 +484,7 @@ export const useGridRowSelection = (
           return;
         }
         const node = tree[id];
-        if (node.type === 'group') {
+        if (node?.type === 'group') {
           const isAutoGenerated = (node as GridGroupNode).isAutoGenerated;
           if (isAutoGenerated) {
             delete selectionLookup[id];

I will open a PR in a minute! 👍🏼

Just noticed that the propagation is not working in that case. Might be a bit harder than originally thought.

Could be a race condition where the tree is not ready yet and the selection takes place already.

I'll add it to the board!