Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupingValueGetter function signature change seems wrong in the v6 to v7 migration guide #12967

Closed
sorinpav opened this issue May 1, 2024 · 1 comment · Fixed by #12969
Closed
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@sorinpav
Copy link

sorinpav commented May 1, 2024

Related page

https://mui.com/x/migration/migration-data-grid-v6/#columns

Kind of issue

Unclear explanations

Issue description

I've been going through the x-data-grid migration guide from v6 to v7, and I think I've spotted an issue.

The groupingValueGetter function signature change - I think the actual signature is similar to the valueGetter signature change.

What the docs say:
image

What I think it is:

-groupingValueGetter: (params) => value,
+valueGetter: (value, row, column, apiRef) => value,

Context

No response

Search keywords: documentation migration guide

@sorinpav sorinpav added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels May 1, 2024
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label May 1, 2024
@MBilalShafi MBilalShafi added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels May 1, 2024
Copy link

github-actions bot commented May 2, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@sorinpav: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants