Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Composition demos/ejection #12430

Open
oliviertassinari opened this issue Mar 12, 2024 · 1 comment
Open

[charts] Composition demos/ejection #12430

oliviertassinari opened this issue Mar 12, 2024 · 1 comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 12, 2024

Summary

Inspired by:

it feels like it would be great to focus on the DX to move from the wrapped/simple mode to the composed mode.

Examples

In practice, maybe it would a demo like it's done for the TextField https://mui.com/material-ui/react-text-field/#components.

Or maybe a separate docs page for each component type:

SCR-20240312-oytm

Motivation

Customizability, it's one of the biggest strengths of Recharts, why it's growing.

It's also part of why there is a purpose for MUI to focus on charts. Why we are working on this (there is value in having a React-only focus take + there is value in having a sustainable model to push recharts forward + highcharts should have an open-core model, it's crazy they don't).

Search keywords: -

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: charts This is the name of the generic UI component, not the React module! waiting for 👍 Waiting for upvotes labels Mar 12, 2024
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 13, 2024
@ttante
Copy link

ttante commented Mar 18, 2024

Bumping this. From the docs online I can't understand how anyone could be expected to use Composition mode.

For example, all the tooltip components listed in the Composition section lack definitions & descriptions on their respective pages and no use example or demo that I can find.

The docs seem to be aimed at existing veterans & experts with x-charts. Most prop descriptions are also very meta and lack an example for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

3 participants