Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix ExpansionPanel migration notes #27352

Merged
merged 1 commit into from
Jul 19, 2021
Merged

[docs] Fix ExpansionPanel migration notes #27352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions docs/src/pages/guides/migration-v4/migration-v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,21 +1243,26 @@ As the core components use emotion as their style engine, the props used by emot
+<Accordion onChange={(event: React.SyntheticEvent, expanded: boolean) => {}} />
```

### ExpansionPanelDetails

- Remove `display: flex` from `AccordionDetails` (formerly `ExpansionPanelDetails`) as its too opinionated.
Most developers expect a display block.

### ExpansionPanelSummary

- Rename `focused` to `focusVisible` for consistency:

```diff
<Accordion
classes={{
<AccordionSummary
classes={{
- focused: 'custom-focus-visible-classname',
+ focusVisible: 'custom-focus-visible-classname',
}}
/>
}}
/>
```

- Remove `display: flex` from AccordionDetails as its too opinionated.
Most developers expect a display block.
- Remove `IconButtonProps` prop from AccordionSummary.
The component renders a `<div>` element instead of an IconButton.
- Remove `IconButtonProps` prop from `AccordionSummary` (formerly `ExpansionPanelSummary`).
The component renders a `<div>` element instead of an `IconButton`.
The prop is no longer necessary.

### Fab
Expand Down