[Menu] Fix scrolling issue #12003
Merged
[Menu] Fix scrolling issue #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
@stephenway Thanks for taking the time to submit a pull request :). |
|
No problem :) |
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
* [Menu] Position menu paper at same level as other relative components to unblock scrolling * [Menu] Switch relative to translate3d technique for better coverage and layout * Update Menu.js
|
@oliviertassinari We got this wrong, I need to submit a new PR to undo this on the menu component and then append the transform on the popover that is scaling(1,1). The scale is winning over the translate that fixed scrolling. I'll do that sometime today. |
|
@stephenway I would be happy to review a even better fix to the problem. |
vharmain
added a commit
to lipas-liikuntapaikat/lipas
that referenced
this pull request
Sep 4, 2018
Applied this manually: mui/material-ui#12003
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening is other elements on the page like Tabs are higher in the z-index by merely being relative elements. So with that we enter a z-index war with elements like this paper menu which aren't raised up in the z-index. Adding translate3d to the paper styles ensures that when it's open, you can interact with the menu for scrolling, otherwise your effectively scrolling the other competing element. Fixes #10601
Updated demo of the fix here
My thanks to @lgerndt for discovering an easy fix.