-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react] Drop support for React v15.x and take advantage of v16.0.0 once released #7670
Comments
@uufish I think that we should wait for officially dropping Check list:
|
children
of type array
supplied to MuiThemeProvider
@oliviertassinari React 16 have already been released, will you remove status onHold from this issue? |
One of react-jss deps contains a library theming with non peer react 15 dependency, seems like it caused a bug in some of our projects |
@istarkov This one was for you #8408 ❤️ . Anyway, this PR #8121 might help as Material-UI runtime code do not rely on |
I have found one limitation with using the new array children capability of React@16. Preact do not support it (preactjs/preact-compat#432). |
There are quite a few other libraries in the eco system that don't support react 15 yet (zeit/next.js) for one so I'd vote to keep react 15 support for a while. It might also help lessen the curve of upgrading to 1.0 from 0.1x |
@eyn zeit/next.js will support react 16 soon: vercel/next.js#2997 (comment) 🎉 |
fyi: next 4 supports react 16 (and dropped 15 support) |
In react@16 we can return an array with the render method.
In this way, should not "MuiThemeProvider" allow arrays?
Versions
The text was updated successfully, but these errors were encountered: