Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] TextField input type #5212

Closed
johnzielke opened this issue Sep 18, 2016 · 5 comments
Closed

[AutoComplete] TextField input type #5212

johnzielke opened this issue Sep 18, 2016 · 5 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@johnzielke
Copy link

I am using the AutoComplete-Component to select a price. The price can either be entered manually, or you can select from a number of precomputed values (hence the AutoComplete and not a TextField). Now it would be really useful to restrict the possible input by setting a type for the TextField the AutoComplete uses. But the AutoComplete component does not expose this property of the underlying TextField. It would be really nice to expose this as well. (This should not be too difficult, and I could probably even create a pull request for that, if this feature makes sense)
Or is there another way to achieve this?

@oliviertassinari oliviertassinari changed the title AutoComplete TextField input type [AutoComplete] TextField input type Sep 20, 2016
@Sharlaan
Copy link

Sharlaan commented Sep 22, 2016

Have you tried ?

Just suggesting because i saw in the AutoComplete source that it passes undocumented props {...other} to the underlying TextField.

@johnzielke
Copy link
Author

Just tried that, and it seems to work fine! Thank you, I somehow missed that... Maybe it would be nice to document this behaviour, or is that documented for all the Components in general somewhere else in the docs?

@jmansor
Copy link

jmansor commented Sep 23, 2016

+1 to add this info to the AutoComplete documentation.

@jmansor
Copy link

jmansor commented Sep 23, 2016

Sent a PR #5243 with this change to the documentation.

@oliviertassinari
Copy link
Member

Closed by #4783

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants