-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mui input base text area style is not applied correctly with input props on 5.15.11 from 5.15.10 #42774
Comments
@ZeeshanTamboli this broke in #40789 and, for some reason #41369 didn't fix it. May I ask you to take a look? Weirdly, the height seems to be multiplied x4 🤔 |
I think I know why this broke. But before explaining, @TangMichael, why are you applying the |
@ZeeshanTamboli We used the After seeing your comments with the rows, I can see that the height of the style is multiplied by the rows number which is why on v5.15.11+, the height is 400 when I have rows set to 4 and the style of the height set to 100. |
If you want the |
The codebase already contained those two props and it worked fine so it was kept like this. We only noticed this issue when upgrading the library version. I can remove one of the other if that fixes the issue. Would you say this is intended behaviour starting from |
This is the correct behavior. It was incorrect before |
Steps to reproduce
Link to live example: (required)
https://stackblitz.com/edit/react-qhoqwr?file=Demo.tsx
Steps:
Current behavior
Height of the component is bigger than 100
Expected behavior
Height should be at 100
Context
Re-making the issue as it was closed previously and I did not get an answer regarding this change of behaviour.
It looks like the first textarea does not contain the style applied to it. I would think it would work fine with the fix done here: #41369
If you were to use the dependency of @mui/material to 5.15.10, using the same props, the textarea will correctly be at 100px. Here is another stackblitz with the dependency updated.
https://stackblitz.com/edit/react-qhoqwr-pewfah?file=package.json
I did not see anything in the release note between 5.15.10 and 5.15.11 that would do this change. Is it possible I am missing something when doing this change?
This is how it looks like with mui 5.15.10
With the exact same code but changing the mui version to 5.15.11+, this is how it looks like:
Your environment
npx @mui/envinfo
Search keywords: input base, text area
The text was updated successfully, but these errors were encountered: