Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Grid] Deprecate the wrap prop #41250

Closed
DiegoAndai opened this issue Feb 23, 2024 · 1 comment · Fixed by #42363
Closed

[material-ui][Grid] Deprecate the wrap prop #41250

DiegoAndai opened this issue Feb 23, 2024 · 1 comment · Fixed by #42363
Assignees
@DiegoAndai
Labels
component: Grid The React component. deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Milestone
Material UI: v6

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 23, 2024 •
edited by oliviertassinari
Loading

Deprecate the wrap prop and mark it as "to be removed".
A codemod should be added alongside it.

Why

It duplicates the flexWrap MUI system property functionality: https://codesandbox.io/s/basicgrid-material-demo-forked-0eebd?file=/demo.tsx.
@DiegoAndai DiegoAndai added component: Grid The React component. deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Feb 23, 2024
@DiegoAndai DiegoAndai added this to the Material UI: v6 milestone Feb 23, 2024
@DiegoAndai DiegoAndai moved this to Selected in Material UI Feb 23, 2024
@DiegoAndai DiegoAndai moved this from Selected to Backlog in Material UI Apr 22, 2024
@fedirjh
Copy link
Contributor

fedirjh commented May 23, 2024

cc @DiegoAndai I will take this one.

@fedirjh fedirjh mentioned this issue May 23, 2024
Merged
1 task
@DiegoAndai DiegoAndai self-assigned this May 24, 2024
@DiegoAndai DiegoAndai moved this from Backlog to In progress in Material UI May 24, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Material UI May 24, 2024
@DiegoAndai DiegoAndai mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoAndai DiegoAndai

Labels
component: Grid The React component. deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
Material UI
Status: Done
Milestone
Material UI: v6
Development

Successfully merging a pull request may close this issue.

[material-ui][Grid] Deprecate wrap prop fedirjh/material-ui
2 participants
@DiegoAndai @fedirjh