Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Divider][material-next] Add Divider component #39007

Open
4 of 8 tasks
Best-Sardar opened this issue Sep 16, 2023 · 4 comments
Open
4 of 8 tasks

[Divider][material-next] Add Divider component #39007

Best-Sardar opened this issue Sep 16, 2023 · 4 comments
Assignees
Labels
component: divider This is the name of the generic UI component, not the React module! design: material you

Comments

@Best-Sardar
Copy link
Contributor

Best-Sardar commented Sep 16, 2023

This issue is to track the work for adding the Divider component to @mui/material-next, moving forward the Material You effort (#29345)

Material You Divider specification: https://m3.material.io/components/divider/overview

Migration Guide steps

  • Copy component files from material (v5) to material-next
  • Remove deprecated components and componentsProps props
  • Drop support for ThemeProvider in favor of CssVarsProvider
  • Migrate component to Typescript
  • Refactor component to use Base UI’s hook if it exists: There's no Base UI hook, pure presentation component
  • Implement Material You design specs: PR #39179
  • Add component playground to v5 docs: PR #39179
  • Refactor styles to use component CSS Variables: WIP @rajvinder-kaur
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 16, 2023
@mj12albert mj12albert added component: divider This is the name of the generic UI component, not the React module! design: material you and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 18, 2023
@rajvinder-kaur
Copy link

can i handle this?

@DiegoAndai DiegoAndai self-assigned this Oct 18, 2023
@DiegoAndai
Copy link
Member

Hey @rajvinder-kaur, thanks for the interest!

The tasks that are not completed are ready to take. Is there a particular one you wish to take?

@rajvinder-kaur
Copy link

i wish to Refactor styles to use component CSS Variables @DiegoAndai

@DiegoAndai
Copy link
Member

@rajvinder-kaur sure, go ahead! Please try to follow Joy's Divider implementation. It's not necessary to have all the variables Joy has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: divider This is the name of the generic UI component, not the React module! design: material you
Projects
None yet
Development

No branches or pull requests

4 participants