Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Diamond sponsors docs layout #38033

Closed
ChetSocio opened this issue Jul 19, 2023 · 10 comments · Fixed by #38410
Closed

[docs-infra] Diamond sponsors docs layout #38033

ChetSocio opened this issue Jul 19, 2023 · 10 comments · Fixed by #38410
Assignees
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product

Comments

@ChetSocio
Copy link

ChetSocio commented Jul 19, 2023

Summary 💡

It seems you have changed the documentation layout in #38410

Screenshot 2023-09-08 at 15 56 57

But it is far more disturbing than helping us. Why did you stick the sponsor's tab in the bottom specifically when every mui user needs to search for components deep down? Also, we get little space to look for the components list.

Examples 🌈

https://mui.com/material-ui/getting-started/installation/

Motivation 🔦

This layout is irritating as hell. The previous layout was quite good and we could see sponsors before components and we had no problem as it was not irritating us. Now it is irritating really.

Screenshot 2023-09-08 at 15 57 27
@ChetSocio ChetSocio added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 19, 2023
@zannager zannager added the website Pages that are not documentation-related, marketing-focused. label Jul 19, 2023
@mnajdova mnajdova assigned danilo-leal and unassigned mnajdova Jul 19, 2023
@danilo-leal
Copy link
Contributor

Hey there @ChetSocio, appreciate the feedback! Our intention with the change was to improve the navigation experience by removing the sponsors from the front & center and giving the side nav content more visibility at first glance at the docs ⎯ but your perspective is valuable and we hadn't considered it before, so thanks again!

To confirm it then, the sponsors being fixed at the bottom is hurting your navigation as you usually are scrolling deep on the list of components?

@danilo-leal danilo-leal added docs Improvements or additions to the documentation design This is about UI or UX design, please involve a designer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer website Pages that are not documentation-related, marketing-focused. labels Jul 19, 2023
@danilo-leal danilo-leal changed the title We want previous MUI .com layout Backkkkk! [docs] We want the previous docs side nav layout back Jul 19, 2023
@ChetSocio
Copy link
Author

ChetSocio commented Jul 19, 2023

yes really, the way it was organized previously was really good and never irritated us.I myself as a visitor loved that and never was a problem when scrolling for components. We could see sponsors as well as downward navigation was a good experience. The way it is now is distrubing as well as irritating . Hope you will do anything about that

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 19, 2023

It feels strange for me too: #38050 (comment).

For now, I don't know if it's because I'm not used to it yet or if something is fundamentally off.

In the latter case ("fundamentally off"), I think that it would be because I tend to expand the navigation at the bottom of my screen, the items I need to see are hidden behind the Dimond sponsors. So each time I can't help myself thinking that if it wasn't for the Diamond sponsors, I could scroll less.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 14, 2023

I'm reopening as we are testing different layouts at this point (directly in production). I think we can update this issue once we settle on a direction.

Right now, we have them in the TOCs:

Screenshot 2023-09-02 at 19 31 40

We are monitoring the impact in: https://analytics.google.com/analytics/web/#/analysis/p353089763/edit/Krwta0OiQ4mQJBZuOexXQA.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 1, 2023

A different type of execution, the first time I see this kind: https://formkit.com/getting-started/what-is-formkit puts the diamond sponsors in a sticky position.

Screen.Recording.2023-09-01.at.19.09.01.mov

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Sep 1, 2023
@oliviertassinari oliviertassinari changed the title [docs] We want the previous docs side nav layout back [docs-infra] Diamond sponsors docs layout Sep 1, 2023
@ChetSocio
Copy link
Author

I am not an contributor to this project but still I think you can put banner ad on top of component's page or footer if advertisement is that much essential. Because in my opinion, if a customer is irritated by the way the ad is placed, then there is rare chance of him/her visiting the sponsor's page thus reducing ctr and conversion. I like the way some websites put the develper-friendly ads on top of web page contents and it is mostly related with programmer's interests. I think MUI also has done it.

@ChetSocio
Copy link
Author

A different type of execution, the first time I see this kind: https://formkit.com/getting-started/what-is-formkit puts the diamond sponsors in a sticky position.

Screen.Recording.2023-09-01.at.19.09.01.mov

Yes, this is acceptable as it will serve it's purpose as well as won't distrub devs

@danilo-leal danilo-leal moved this to Feeling it in Docs-infra Oct 26, 2023
@danilo-leal
Copy link
Contributor

@oliviertassinari Shall we close this one as per the recent email thread you sent out about this topic?

@ChetSocio
Copy link
Author

Yup I am closing this as you seem to have done what i was thinking and now its a lot better on right side . You got many benefits: its easy to click on right side than left side, its now visible properly, it is not distrubing devs anymore. Thanks

@github-project-automation github-project-automation bot moved this from Feeling it to Done in Docs-infra Oct 29, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 2, 2023

Shall we close this one as per the recent email thread you sent out about this topic?

@danilo-leal the thread in question: https://groups.google.com/a/mui.com/g/core/c/NMMUNFCsayM.

Yes, I think we can close. With the data we have available the current placement seems to be our least worth option.

Another angel I didn't use in that thread: considering the alternative libraries we compete with, this ad placement seems to be the one that has the least potential to negatively differentiate us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants