Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider][material-next] Add Slider component #37527

Closed
8 tasks done
DiegoAndai opened this issue Jun 6, 2023 · 1 comment
Closed
8 tasks done

[Slider][material-next] Add Slider component #37527

DiegoAndai opened this issue Jun 6, 2023 · 1 comment
Assignees
Labels
component: slider This is the name of the generic UI component, not the React module! design: material you design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Jun 6, 2023

This issue is to track the work for adding the Slider component to @mui/material-next, moving forward the Material You effort (#29345)

Material You Slider specification: https://m3.material.io/components/sliders/overview

Migration Guide steps

  • Copy component files from material (v5) to material-next: PR #37520
  • Remove deprecated components and componentsProps props: PR #37520
  • Drop support for ThemeProvider in favor of CssVarsProvider: PR #37520
  • Migrate component to Typescript (test files in separate task below): PR #37520
  • Refactor component to use Base UI’s hook if it exists: Skipped, was already using Base's hook in v5.
  • Implement Material You design specs: PR #37520
  • Add component playground to v5 docs: PR #37520

Additional work

Work split into follow up issues

  • Migrate Slider.test.js to TS: #38021
  • Refactor styles to use CSS Variables: #38981
  • Implement opacity-based disabled state: #38982

Note: If a task is marked as [WIP] it means someone is working on it

@DiegoAndai DiegoAndai self-assigned this Jun 6, 2023
@DiegoAndai DiegoAndai converted this from a draft issue Jun 6, 2023
@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process component: slider This is the name of the generic UI component, not the React module! v6.x labels Jun 6, 2023
@DiegoAndai DiegoAndai linked a pull request Jun 7, 2023 that will close this issue
2 tasks
@mnajdova mnajdova moved this from In progress to Done in Joy UI Jul 21, 2023
@mnajdova mnajdova moved this from Done to In progress in Joy UI Jul 21, 2023
@DiegoAndai
Copy link
Member Author

There are still improvements to be made to this component, but the main work has already been completed.

I've created separate issues to track some of the improvements I have in mind.

I'm closing this issue as the component is ready to be used, and I see no use in keeping it open as an umbrella issue.

@github-project-automation github-project-automation bot moved this from In progress now to Recently completed in Joy UI Sep 14, 2023
@DiegoAndai DiegoAndai added v7.x and removed v6.x labels Dec 26, 2023
@DiegoAndai DiegoAndai added this to the Material UI: v7 draft milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! design: material you design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants