Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RadioButton] value of type 'any' #3698

Closed
FranBran opened this issue Mar 15, 2016 · 2 comments · Fixed by #4510
Closed

[RadioButton] value of type 'any' #3698

FranBran opened this issue Mar 15, 2016 · 2 comments · Fixed by #4510
Labels
bug 🐛 Something doesn't work

Comments

@FranBran
Copy link

why only accepting value of type React.PropTypes.string instead of React.PropTypes.any?
@alitaheri
Copy link
Member

@DERIIIFranz you are right. it should be any. there is also another problem with it. falsy values break it's behavior. A PR would be welcome 😅

@alitaheri alitaheri added the bug 🐛 Something doesn't work label Mar 15, 2016
@aahan96 aahan96 mentioned this issue Jun 16, 2016
Merged
3 tasks
@aahan96
Copy link
Contributor

aahan96 commented Jun 17, 2016

@alitaheri Can you check the PR regarding this issue? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RadioButton] Changed the value type to any aahan96/material-ui
3 participants
@FranBran @aahan96 @alitaheri