Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Handle @mui/material/styles in jss-to-styled #28666

Closed
iamstiil opened this issue Sep 28, 2021 · 3 comments · Fixed by #28667
Closed

[codemod] Handle @mui/material/styles in jss-to-styled #28666

iamstiil opened this issue Sep 28, 2021 · 3 comments · Fixed by #28667
Assignees
@mnajdova
Labels
package: system Specific to @mui/system

Comments

@iamstiil
Copy link

Hey, while migrating I found this.

I think in this line and in this line, @mui/material/styles should be used by default. @material-ui/core/styles should only be used if an import already exists, which means preset-safe was not executed.

Not sure if I'm right, but felt like it 😄
@mnajdova
Copy link
Member

@iamstiil oops looks like we forgot to update this :\ Thanks for the report.

@mnajdova mnajdova self-assigned this Sep 28, 2021
@mnajdova mnajdova mentioned this issue Sep 28, 2021
Merged
@el-frontend
Copy link

I was going to report the exact same thing. Greetings

@mnajdova
Copy link
Member

It was fixed, thanks again!

@zannager zannager added the package: system Specific to @mui/system label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnajdova mnajdova

Labels
package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[codemod] Update the imports in jss-to-styled to match the new package names mnajdova/material-ui
4 participants
@mnajdova @iamstiil @el-frontend @zannager