Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Disabled loading button text is sometimes transparent #26833

Closed
2 tasks done
alexdaube opened this issue Jun 18, 2021 · 2 comments · Fixed by #26857
Closed
2 tasks done

[Button] Disabled loading button text is sometimes transparent #26833

alexdaube opened this issue Jun 18, 2021 · 2 comments · Fixed by #26857
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module!

Comments

@alexdaube
Copy link

alexdaube commented Jun 18, 2021 •
edited
Loading

Loading button label/text is transparent in disabled mode.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

In lab version 5.0.0-alpha.37, the LoadingButton's label is shown transparent when disabled={true}. This seems to only be the case when there are no startIcon or endIcon specified in the component.

Screen Shot 2021-06-18 at 5 45 44 PM

Expected Behavior 🤔

The label should be visible by default.

Steps to Reproduce 🕹

https://codesandbox.io/s/loadingbuttonstransition-material-demo-forked-xjdo0?file=/demo.tsx

Your Environment 🌎

Version:

  • @material-ui/lab 5.0.0-alpha.37
  • @material-ui/core 5.0.0-alpha.37
@alexdaube alexdaube added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 18, 2021
@alexdaube alexdaube changed the title [v5][IconButton] Disabled loading button text is sometimes transparent [v5][LoadingButton] Disabled loading button text is sometimes transparent Jun 18, 2021
@DanielBretzigheimer DanielBretzigheimer mentioned this issue Jun 20, 2021
Merged
1 task
@DanielBretzigheimer
Copy link
Contributor

I have created a PR (#26857) which fixes the issue.

@oliviertassinari
Copy link
Member

It also resonates with: #26666 (comment)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2021
@oliviertassinari oliviertassinari changed the title [v5][LoadingButton] Disabled loading button text is sometimes transparent [Button] Disabled loading button text is sometimes transparent Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Button] Fix loading text invisible when disabled DanielBretzigheimer/material-ui
3 participants
@oliviertassinari @alexdaube @DanielBretzigheimer