Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateRangePicker] Does not open on trigger click #24937

Closed
2 tasks done
dborstelmann opened this issue Feb 14, 2021 · 11 comments · Fixed by #26016
Closed
2 tasks done

[DateRangePicker] Does not open on trigger click #24937

dborstelmann opened this issue Feb 14, 2021 · 11 comments · Fixed by #26016
Assignees
Labels
bug 🐛 Something doesn't work component: date range picker This is the name of the generic UI component, not the React module!

Comments

@dborstelmann
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Clicking input doesn't open datepicker.
https://codesandbox.io/s/lingering-moon-2t7o3?file=/src/App.tsx

Expected Behavior 🤔

Clicking input opens datepicker.
https://codesandbox.io/s/stupefied-waterfall-9md45?file=/src/App.tsx

Steps to Reproduce 🕹

Steps:

  1. Upgrade from 24 to 25 for core and lab.

Context 🔦

The only thing I changed was upgrading, it is now broken in new release. There is weird behavior where tabbing into the input shows it, or changing windows or tabs and coming back opens it if the field is already highlighted. But clicking input does not open the picker (well it flickers like it opens and closes immediately).

Your Environment 🌎

See codesandbox examples.

@dborstelmann dborstelmann added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 14, 2021
@dborstelmann
Copy link
Contributor Author

dborstelmann commented Feb 14, 2021

I would assume this is a regression from: #24653

@dborstelmann
Copy link
Contributor Author

@eps1lon Tagging you in here because you probably have context.

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 14, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 14, 2021

Related to #24874

@oliviertassinari oliviertassinari marked this as a duplicate of #24874 Feb 14, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: date range picker This is the name of the generic UI component, not the React module! and removed duplicate This issue or pull request already exists labels Feb 14, 2021
@oliviertassinari oliviertassinari changed the title [Datepickers] Broken in new release (alpha 25) [DateRangePicker] Broken in new release (alpha 25) Feb 14, 2021
@oliviertassinari oliviertassinari marked this as not a duplicate of #24874 Feb 14, 2021
@eps1lon eps1lon changed the title [DateRangePicker] Broken in new release (alpha 25) [DateRangePicker] Does not open on trigger click Feb 14, 2021
@Xhale1
Copy link

Xhale1 commented Feb 16, 2021

I have run into the same issue with the DatePicker and TimePicker components.

Upgrading lab and core to alpha 25 causes the issue, reverting lab and core to alpha 24 fixes the issue. Only other installed M-UI packages are icons alpha 24.

@dborstelmann
Copy link
Contributor Author

Just downloaded the new version (alpha 26) and this is not fixed sadly. @eps1lon

@dborstelmann
Copy link
Contributor Author

Just an FYI, I'm on React 16 not 17, not sure if that's an issue?

@eps1lon eps1lon self-assigned this Mar 1, 2021
@dborstelmann
Copy link
Contributor Author

@eps1lon any updates here? Just curious because it's blocking our launch with Material v5. Let me know if there is anything I can do to help.

@eps1lon
Copy link
Member

eps1lon commented Mar 11, 2021

@eps1lon any updates here? Just curious because it's blocking our launch with Material v5. Let me know if there is anything I can do to help.

We'll notify once this is fixed. Please consider the effects of issue bumping.

@dborstelmann
Copy link
Contributor Author

Just curious, would a workaround here be to move to React 17? I can do that if that solves it in the short term. I just didn't want to upgrade yet if the bug still exists there

@chillyistkult
Copy link

chillyistkult commented Apr 6, 2021

Just curious, would a workaround here be to move to React 17? I can do that if that solves it in the short term. I just didn't want to upgrade yet if the bug still exists there

No upgrading to react 17 won't help. Even with latest release (v5.0.0-alpha.29 v5.0.0-alpha.30) it's still broken.

@dborstelmann
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: date range picker This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants