Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default classes on table component #2440

Closed
anthony-dandrea opened this issue Dec 9, 2015 · 3 comments · Fixed by #2630
Closed

Remove default classes on table component #2440

anthony-dandrea opened this issue Dec 9, 2015 · 3 comments · Fixed by #2630
Labels
bug 🐛 Something doesn't work

Comments

@anthony-dandrea
Copy link

Maybe there's a reason I don't know of for them to be there. But it seems like bloat and if there are classnames added to just be added. I have already run into a conflict with a foundation style:

class*="column"]+[class*="column"]:last-child {
    float: right;
}

It unintentionally targets .mui-table-row-column and .mui-table-header-column.

@alitaheri
Copy link
Member

@anthony-dandrea Yeah we've been meaning to do that. but that's a breaking change.

@oliviertassinari @shaurya947 Should we push this breaking change to 0.14.0? this can annoy a lot of people.

@alitaheri alitaheri added the bug 🐛 Something doesn't work label Dec 9, 2015
@anthony-dandrea
Copy link
Author

I see. In hindsight I could see how these classes would make it easier for people to write styles. Maybe if there was a prop to turn off the default class. Or if className="" set the className to an empty string.

@alitaheri
Copy link
Member

actually we plan to ONLY support className which defaults to ''
So, yeah we'd like to do that. but it's a breaking change. it must be planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants