LeftNav componentWillReceiveProps open-state conflict

[rhythnic]

For me, the componentWillReceiveProps callback is setting state.open to true before the call to setState({open: false}) inside of the close function has had time to take effect, preventing the menu from closing when the close or toggle methods are called. I've commented out the line to set state.open inside of component will receive props as as workaround. To fix this, I think that state.open should only be set inside of componentWillReceiveProps if props.docked !== nextProps.docked.

[craig-jennings]

I'm also having this problem. The related code change is #2044. I'm calling leftNav.close() and then routing my app causing a re-render. When componentsWillReceiveProps is called, since docked hasn't changed it sets open = this.state.open which hasn't yet been updated from the close() call. This blocks the leftNav from closing because now open has been reset to true.

[oliviertassinari]

Sounds like we can do an easy fix. Do you want to give a try?

[rhythnic]

If you don't want to change the API to use props.open, this should fix the bug. Pull Request
Otherwise, just ignore the pull request.

[oliviertassinari]

If you don't want to change the API to use props.open

I think that It will be better to remove this imperative close method as we did with the Dialog.
Anyway, that's a regression and we have to fix it.
Thanks guys.

[alitaheri]

I think this should be fixed with #2180 can you check again @rhythnic ?

[rhythnic]

@subjectix yes, it's working now.